Skip to content

Add experimental draft support for GPML-style graph query parsing #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add experimental draft support for GPML-style graph query parsing #148

wants to merge 3 commits into from

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Jul 6, 2022 •
edited
Loading

This adds addtional features to the draft parser/AST support for a subset of GPML as outlined by Graph Pattern Matching in GQL and SQL/PGQ. The use within the grammar is based on the assumption of a new graph data type being added to the specification of data types within PartiQL, and should be considered experimental until the semantics of the graph data type are specified.

Added by this PR:

  • basic and abbreviated node and edge patterns (section 4.1 of the GPML paper)
  • concatenated path patterns (section 4.2 of the GPML paper)
  • path variables (section 4.2 of the GPML paper)
  • graph patterns (i.e., comma separated path patterns) (section 4.3 of the GPML paper)
  • AST support for path quantifiers (section 4.4 of the GPML paper)
  • parenthesized patterns (section 4.4 of the GPML paper)
  • parsing support for path quantifiers (section 4.4 of the GPML paper)
  • restrictors and selector (section 5.1 of the GPML paper)
  • parsing support for pre-filters and post-filters (section 5.2 of the GPML paper)
  • AST support for pre-filters (section 5.2 of the GPML paper)

GPML features not yet implemented:

  • group variables (section 4.4 of the GPML paper)
  • path pattern union and multiset (section 4.5 of the GPML paper)
  • conditional variables (section 4.6 of the GPML paper)
  • graphical predicates (section 4.7 of the GPML paper)
  • aggregates of unbounded variables (section 5.3 of the GPML paper)

Similar functionality and test cases as introduced by:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 July 6, 2022 04:33
@jpschorr jpschorr changed the title experimental GPML Add experimental draft support for GPML-style graph query Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022 •
edited
Loading

Conformance comparison report

main (17cbcb5) 7803e5d +/-
% Passing 78.00% 78.00% 0.00%
✅ Passing 344 344 0
❌ Failing 0 0 0
🔶 Ignored 97 97 0
Total Tests 441 441 0

Number passing in both: 344

Number failing in both: 0

Number passing in main but now fail: 0

Number failing in main but now pass: 0

@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.47287% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.53%. Comparing base (17cbcb5) to head (b8180c5).
⚠️ Report is 277 commits behind head on main.

Files with missing lines Patch % Lines
partiql-ast/src/ast.rs 78.26% 10 Missing ⚠️
partiql-parser/src/lexer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   87.32%   87.53%   +0.21%     
==========================================
  Files          23       23              
  Lines        2383     2512     +129     
==========================================
+ Hits         2081     2199     +118     
- Misses        302      313      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpschorr jpschorr requested a review from vgapeyev July 7, 2022 17:17
@jpschorr jpschorr marked this pull request as draft August 10, 2022 17:56
@jpschorr jpschorr force-pushed the spike-gpml branch 2 times, most recently from a25262c to 2039f20 Compare September 28, 2022 17:50
@jpschorr
Experimental support for MATCH as expr.
a1215a5 
- Still doesn't allow edge as first part of a non-nested pattern
- Requires parens around entire MATCH expression
@jpschorr jpschorr changed the title Add experimental draft support for GPML-style graph query Add experimental draft support for GPML-style graph query parsing Mar 22, 2023
@jpschorr jpschorr mentioned this pull request Mar 18, 2025
Merged
@alancai98
Copy link
Member

Probably we can close this PR since #548 is more up-to-date?

@jpschorr
Copy link
Contributor Author

Graph query was implemented separately and published in

@jpschorr jpschorr closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am357 am357 Awaiting requested review from am357

@vgapeyev vgapeyev Awaiting requested review from vgapeyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpschorr @alancai98